Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'extra comma inserted due to comment' #3677

Merged
merged 2 commits into from
Jul 14, 2019
Merged

fix 'extra comma inserted due to comment' #3677

merged 2 commits into from
Jul 14, 2019

Conversation

rchaser53
Copy link
Contributor

fix: #3675

scampi
scampi approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In #3680 I have added a unit test for extract_post_comment. Can you share the inputs of this method that triggered the problem ? I'd like to add a test case for it. Thanks!

@rchaser53
Copy link
Contributor Author

Yes I can share it. What do you want me to do?
#3680 is a WIP. Should I wait at #3680 merge and add a test to this PR?

@scampi
Copy link
Contributor

scampi commented Jul 14, 2019

Just share the inputs in a comment here, i'll add the test case. No need to block this PR.

@rchaser53
Copy link
Contributor Author

I see. Thank you.

@topecongiro topecongiro merged commit 71289e1 into rust-lang:master Jul 14, 2019
@topecongiro topecongiro added this to the 1.3.3 milestone Jul 14, 2019
@rchaser53 rchaser53 deleted the issue-3675 branch July 14, 2019 13:42
@scampi
Copy link
Contributor

scampi commented Jul 16, 2019

I'm not able to reproduce the problem in #3680 , could be because I've added another condition to that method...

@scampi scampi mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scampi scampi scampi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.3
Development

Successfully merging this pull request may close these issues.

extra comma inserted due to comment
3 participants
@rchaser53 @scampi @topecongiro