Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show configs from different versions on github pages #4221

Merged
merged 3 commits into from
Jun 1, 2020

Conversation

ayazhafiz
Copy link
Contributor

@ayazhafiz ayazhafiz commented Jun 1, 2020

See https://pithecoidstreet.htmlpasta.com/ for a demo of this change.

Part of #4178

@ayazhafiz ayazhafiz requested a review from topecongiro June 1, 2020 01:17
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Could we also add a note to the Configurations.md file with a link to this GH pages so folks know to go there for version-specific config info?

@ayazhafiz
Copy link
Contributor Author

@calebcartwright ptal.

Can we list the pages site in the repo description?


For version- and channel-specific configurations, please visit https://rust-lang.github.io/rustfmt/.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@karyon
Copy link
Contributor

karyon commented Oct 26, 2021

backported in #4958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants