Remove unstable option license_template_path
#5246
Closed
+2
−388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes 5103 It was decided that rustfmt is not the right tool to provide this feature.
|
Thanks for this, though I'm going to close as I'm still holding off on the removal for a bit longer. I'll drop all three in unison when it's time |
|
No worries, I thought I'd get the ball rolling on the planned removals. I was going to follow up with PRs to remove the other options, but totally understand if you want to do that all in one go. |
FintanH
added a commit
to radicle-dev/radicle-surf
that referenced
this pull request
Jul 11, 2022
Update to rust-1.62.0[0]. This requires converting `push_str` + `format!` calls into a `write!` call. Remove `license_template_path` since it is deprecated[1]. [0]: https://blog.rust-lang.org/2022/06/30/Rust-1.62.0.html [1]: rust-lang/rustfmt#5246 Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5103
It was decided that rustfmt is not the right tool to provide this feature.