Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bootstrap for stage0 #860

Merged

Conversation

vertexclique
Copy link
Member

Amanieu mentioned that stage0 build should exclude TME for Aarch64 in here: rust-lang/rust#72749 (comment)

r? @Amanieu

@Amanieu
Copy link
Member

Amanieu commented May 29, 2020

You also need to #[cfg] out the use line below.

@vertexclique vertexclique force-pushed the vcq/tme-disable-bootstrap-for-stage0 branch from bae07aa to 219f7ba Compare May 29, 2020 19:58
@vertexclique
Copy link
Member Author

Yup, forgot that.

@Mark-Simulacrum
Copy link
Member

Before we land this -- I want to be sure that I'm following correctly -- this will not break when we update the bootstrap compiler, right? It'll just retain less functionality? Historically having cfg(bootstrap) outside of rust-lang/rust proper is pretty painful so it would be good to avoid this if possible (say, by waiting ~1 week after bootstrap is bumped in rust-lang/rust).

@Amanieu
Copy link
Member

Amanieu commented May 29, 2020

Actually I think the issue is not due to stage0. Looking at the CI logs it seems that rustdoc is failing because it doesn't recognize the "tme" target feature. Why is stage0 rustdoc used here?

@Amanieu
Copy link
Member

Amanieu commented May 29, 2020

Sorry it seems I was wrong about the issue. I'll close this and we can continue discussion in rust-lang/rust#72749.

@Amanieu Amanieu closed this May 29, 2020
@Amanieu
Copy link
Member

Amanieu commented May 29, 2020

Reopening as per rust-lang/rust#72749 (comment)

@Amanieu Amanieu reopened this May 29, 2020
@Amanieu Amanieu merged commit 01db337 into rust-lang:master May 29, 2020
@Amanieu
Copy link
Member

Amanieu commented May 29, 2020

Please update your submodule in the other PR to include this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants