Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Rustc Trait System Refactor Initiative #887

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 9, 2022

cc rust-lang/types-team#58

I've added every one who is already a part of an existing team and mentioned that they're interested in rust-lang/types-team#58 to the initiative for now: @BoxyUwU @cjgillot @compiler-errors @spastorino.

Not sure if opening a new repository for the initiative is too useful as it would only contain 2-4 documents and in my experience initiative repos are somewhat hard to discover. I don't know, maybe having that repo is actually really useful '^^ can still make a new one at that point

@rust-lang/types for review/approval

@lcnr
Copy link
Contributor Author

lcnr commented Nov 9, 2022

changed it to be a subteam of compiler as types is already a subteam of it and having subteams of a subteam isn't allowed.

@lcnr lcnr force-pushed the trait-system-rewrite branch from 54d97a5 to 6c914c6 Compare November 9, 2022 21:19
jackh726
jackh726 previously approved these changes Nov 9, 2022
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rewrite -> refactor. Other than that, LGTM.

@lcnr lcnr changed the title add Rustc Trait System Rewrite Initiative add Rustc Trait System Refactor Initiative Nov 10, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Nov 10, 2022

👍 changed to refactor.

@jackh726
Copy link
Member

Ah wait, do we want a zulip stream? Do you think it'd be useful?

@rylev
Copy link
Member

rylev commented Nov 11, 2022

Zulip streams aren't yet configured through this repo. You'll have to ask #infra on Zulip for that for now.

name = "project-trait-system-refactor"
kind = "project-group"
# Really should be types, but types is already a subteam,
# so that's not allowed for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietroalbini do you know why this restriction was put in place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe because we of the governance webpage as there's currently a 1 to 1 correspondence between the parent team and the governance page: https://www.rust-lang.org/governance/teams/compiler 🤔

@lcnr
Copy link
Contributor Author

lcnr commented Nov 14, 2022

Ah wait, do we want a zulip stream? Do you think it'd be useful?

Will try and experiment with project boards for this: https://github.com/orgs/rust-lang/projects/26/views/1. For that each area should then have a project board entry and a https://github.com/rust-lang/rust issue.

We could have a zulip stream with a thread for each of these issues, but I don't think that's too helpful. If we just need a place to discuss the impl of issues or general questions, staying in the #t-types stream is probably better as its easier to discover. Don't expect that we're going to have too many zulip topics for this initiative so using the #t-types stream should not drown out other work.

@rylev rylev merged commit 4fbf106 into rust-lang:master Nov 15, 2022
@lcnr lcnr deleted the trait-system-rewrite branch November 15, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants