-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add beta nominated to issues fixing regressions #1380
Open
mibac138
wants to merge
2
commits into
rust-lang:master
Choose a base branch
from
mibac138:nominate-beta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
use crate::config::BetaBackportConfig; | ||
use crate::github::{IssuesAction, IssuesEvent, Label}; | ||
use crate::handlers::Context; | ||
use regex::Regex; | ||
|
||
lazy_static! { | ||
// See https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-issues/linking-a-pull-request-to-an-issue | ||
static ref CLOSES_ISSUE: Regex = Regex::new("(close[sd]|fix(e[sd])?|resolve[sd]) #(\\d+)").unwrap(); | ||
} | ||
|
||
pub(crate) struct BetaBackportInput { | ||
ids: Vec<u64>, | ||
} | ||
|
||
pub(crate) fn parse_input( | ||
_ctx: &Context, | ||
event: &IssuesEvent, | ||
config: Option<&BetaBackportConfig>, | ||
) -> Result<Option<BetaBackportInput>, String> { | ||
if config.is_none() { | ||
return Ok(None); | ||
} | ||
|
||
if event.action != IssuesAction::Opened { | ||
return Ok(None); | ||
} | ||
|
||
if event.issue.pull_request.is_none() { | ||
return Ok(None); | ||
} | ||
|
||
let mut ids = vec![]; | ||
for caps in CLOSES_ISSUE.captures_iter(&event.issue.body) { | ||
let id = caps.get(1).unwrap().as_str(); | ||
let id = match id.parse::<u64>() { | ||
Ok(id) => id, | ||
Err(err) => { | ||
return Err(format!("Failed to parse issue id `{}`, error: {}", id, err)); | ||
} | ||
}; | ||
ids.push(id); | ||
} | ||
|
||
return Ok(Some(BetaBackportInput { ids })); | ||
} | ||
|
||
pub(super) async fn handle_input( | ||
ctx: &Context, | ||
config: &BetaBackportConfig, | ||
event: &IssuesEvent, | ||
input: BetaBackportInput, | ||
) -> anyhow::Result<()> { | ||
let mut issues = input | ||
.ids | ||
.iter() | ||
.copied() | ||
.map(|id| async move { event.repository.get_issue(&ctx.github, id).await }); | ||
|
||
let trigger_labels: Vec<_> = config | ||
.trigger_labels | ||
.iter() | ||
.cloned() | ||
.map(|name| Label { name }) | ||
.collect(); | ||
while let Some(issue) = issues.next() { | ||
let issue = issue.await.unwrap(); | ||
if issue | ||
.labels | ||
.iter() | ||
.any(|issue_label| trigger_labels.contains(issue_label)) | ||
{ | ||
let mut new_labels = event.issue.labels().to_owned(); | ||
new_labels.extend( | ||
config | ||
.labels_to_add | ||
.iter() | ||
.cloned() | ||
.map(|name| Label { name }), | ||
); | ||
return event.issue.set_labels(&ctx.github, new_labels).await; | ||
} | ||
} | ||
|
||
Ok(()) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to trigger a beta-backport nomination for any PR that is fixing an issue, no matter if the originating issue is a regression and the channel (nightly, beta or stable) where the regression happened?
(sorry if I missing some context)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mibac138