Explain that the assignee is not necessarily the reviewer #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
force-pushed
the
auto-assign-message
branch
from
51dd7b6 to
ef9d7c1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
wesleywiser
approved these changes
Feb 7, 2024
|
One week is pretty quick? Don't we normally say 2 weeks? |
oli-obk
force-pushed
the
auto-assign-message
branch
from
ef9d7c1 to
9aa64e1
Compare
jackh726
approved these changes
Feb 7, 2024
klensy
reviewed
Feb 7, 2024
Comment on lines
+61
to
+62
| They will have a look at your PR within the next two weeks and either review your PR or | ||
| reassign to another reviewer. |
There was a problem hiding this comment.
Need a line break, or it will look not nice, rust-lang/rust#120750 (comment)
There was a problem hiding this comment.
Whoops. Will open a PR tomorrow
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also give "one week" as the timeframe within any reaction (reassignment, "will take longer to review", or a review) will happen. Happy to increase the time here.
Related discussion: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/review.20queue.20.26.20capacity
cc @rust-lang/compiler