Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Move error and dpi types into a separate crate + split out x11 symbol loading code + xinerama & multihead support #1298

Closed

Conversation

goddessfreya
Copy link
Contributor

@goddessfreya goddessfreya commented Nov 30, 2019

See https://github.com/rust-windowing/winit_types and https://github.com/rust-windowing/glutin_x11_sym.

@murarth @Osspial Are you folks familiar with how to setup CI for glutin_x11_sym, glutin_sys and winit_types?

Platforms:

  • X11
  • Wayland
  • Macos
  • Windows
  • iOS
  • Web

Other:

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@goddessfreya goddessfreya changed the title [DRAFT] Move error and dpi types into a separate crate. [DRAFT] Move error and dpi types into a separate crate and split out x11 symbol loading code. Nov 30, 2019
@goddessfreya goddessfreya added C - in progress Implementation is proceeding smoothly S - enhancement Wouldn't this be the coolest? labels Dec 1, 2019
@goddessfreya
Copy link
Contributor Author

goddessfreya commented Dec 1, 2019

Hey @simlay, can you implement this for iOS? I couldn't get cargo check to work for iOS as it needed some SDK (which is of course macos only :/). Thanks ❤️

@simlay
Copy link
Contributor

simlay commented Dec 1, 2019

Sure! I’ll give it a whack!

@vbogaevsky
Copy link
Contributor

Weren't we going to merge dpi_overhaul first?

@goddessfreya
Copy link
Contributor Author

@vbogaevsky I don't think it particularly matters which order they land, does it? These changes don't really touch anything dpi related.

@Osspial
Copy link
Contributor

Osspial commented Dec 2, 2019

@goddessfreya The DPI overhaul branch adds generics to the size and position types, and it'll be easier to manage this change if we delay merging this until after the generics have landed on master.

@goddessfreya goddessfreya changed the title [DRAFT] Move error and dpi types into a separate crate and split out x11 symbol loading code. [DRAFT] Move error and dpi types into a separate crate + split out x11 symbol loading code + xinerama & multihead support Dec 27, 2019
Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
dvc94ch and others added 3 commits February 14, 2020 06:26
@daxpedda
Copy link
Member

daxpedda commented Jun 2, 2023

This is very old and needs to be remade completely.

Continues to be tracked in #2759.

@daxpedda daxpedda closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants