Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Use mouse events instead of pointer events if the latter isn't supported #1630

Merged
merged 4 commits into from
Aug 5, 2020

Conversation

hayashi-stl
Copy link
Contributor

@hayashi-stl hayashi-stl commented Jul 23, 2020

Pointer events aren't supported on Safari yet, so this pull request uses mouse events when pointer events aren't supported on the web.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Copy link
Contributor

@ryanisaacg ryanisaacg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Two quick nits:

  • Could you address the compilation warnings that this change introduces?
  • Would you like to do the same change for the stdweb backend?

@hayashi-stl
Copy link
Contributor Author

I'm not experienced with stdweb, so I'm not as confident about fixing the problem for that backend.

@ryanisaacg ryanisaacg merged commit 05fdcb5 into rust-windowing:master Aug 5, 2020
@alvinhochun
Copy link
Contributor

Pointer events aren't supported on Safari yet

According to https://caniuse.com/#feat=pointer, Safari 13 does support pointer events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants