[X11] Create windows with a parent window #2096
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can create windows with a user-specified parent window. It's intended to realize what discussed in issue #159 for X11.
EDITED:
For compatibility, this introduces a new methodnew_x11_any_thread_with_root()
to create such windows. I considered to change the signature ofnew_x11_any_thread()
, it takes a parent window ID, but I cannot decide that so simply create a new method. I want to discuss about this point.The way above was an wrong way. For now this PR adds
with_x11_parent()
method toWindowBuilder
by importingwinit::platform::unix::WindowBuilderExtUnix
, we can set X11 window ID as a parent with it. It seems good because it's similar way in supporting child window in Windows (#96).By the way this PR is for my VST3 plugin using vst3-sys so I don't have any ideas to test this PR without VST3 codes. I want some advice about testing.This PR adds example code and it works.cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to users