Composition event on web #2173
Closed
Composition event on web #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change requires x11-dl crate Also, I should send actual string in IME Co-authored-by: Murarth <murarth@gmail.com>
Co-authored-by: Kirill Chibisov <contact@kchibisov.com>
remove unused web_sys features
madsmtm
added
DS - web
C - waiting on maintainer
12 tasks
add event debug print to investigate some lack of feature on android.
This commit brings new IME event to account for preedit state of input method, also adding `Window::set_ime_allowed` to toggle IME input on the particular window. This commit implements API as designed in #1497 for desktop platforms. Co-authored-by: Artur Kovacs <kovacs.artur.barnabas@gmail.com> Co-authored-by: Murarth <murarth@gmail.com> Co-authored-by: Yusuke Kominami <yukke.konan@gmail.com> Co-authored-by: moko256 <koutaro.mo@gmail.com>
kchibisov
force-pushed
the
composition-event
branch
from
bc90c3d to
a90407a
Compare
…/winit into rw-composition-event # Conflicts: # CHANGELOG.md # src/event.rs # src/platform_impl/linux/wayland/window/shim.rs # src/window.rs
This commit brings new IME event to account for preedit state of input method, also adding `Window::set_ime_allowed` to toggle IME input on the particular window. This commit implements API as designed in #1497 for desktop platforms. Co-authored-by: Artur Kovacs <kovacs.artur.barnabas@gmail.com> Co-authored-by: Murarth <murarth@gmail.com> Co-authored-by: Yusuke Kominami <yukke.konan@gmail.com> Co-authored-by: moko256 <koutaro.mo@gmail.com>
kchibisov
force-pushed
the
composition-event
branch
from
a90407a to
3c0a180
Compare
kchibisov
force-pushed
the
composition-event
branch
4 times, most recently
from
2a0f171 to
98540a6
Compare
kchibisov
force-pushed
the
composition-event
branch
2 times, most recently
from
86c5257 to
0f30ac6
Compare
|
i don't have enough time to work on this PR. |
kchibisov
force-pushed
the
composition-event
branch
from
f699224 to
aa9c7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to userscurrent tested platform
buggy platforms
expected preferable behavior Firefox with MS Swiftkey
compositionstart: compositionupdate: ん compositionupdate: に compositionupdate: にh compositionupdate: にほ compositionupdate: にほん compositionupdate: にほんg compositionupdate: にほんご compositionupdate: にほんごん compositionupdate: にほんごんy compositionupdate: にほんごにゅ compositionupdate: にほんごにゅう compositionupdate: にほんごにゅうr compositionupdate: にほんごにゅうry compositionupdate: にほんごにゅうりょ compositionupdate: にほんごにゅうりょk compositionupdate: にほんごにゅうりょく compositionupdate: 日本語入力 compositionend: 日本語入力buggy behavior Chrome with MS Swiftkey
compositionstart: compositionupdate: compositionstart: compositionupdate: ん compositionend: ん compositionstart: compositionupdate: ん compositionupdate: に compositionend: に compositionstart: compositionupdate: にh compositionupdate: にほ compositionend: にほ compositionstart: compositionupdate: にほ compositionupdate: にほん compositionend: にほん compositionstart: compositionupdate: にほんg compositionupdate: にほんご compositionend: にほんご compositionstart: compositionupdate: にほんご compositionupdate: にほんごん compositionend: にほんごん compositionstart: compositionupdate: にほんごんy compositionupdate: にほんごにゅ compositionend: にほんごにゅ compositionstart: compositionupdate: にほんごにゅ compositionupdate: にほんごにゅう compositionend: にほんごにゅう compositionstart: compositionupdate: にほんごにゅうry compositionupdate: にほんごにゅうりょ compositionend: にほんごにゅうりょ compositionstart: compositionupdate: にほんごにゅうりょk compositionupdate: にほんごにゅうりょく compositionend: にほんごにゅうりょく compositionstart: compositionupdate: にほんごにゅうりょく compositionupdate: nihongonyuuryoku compositionend: nihongonyuuryokuHow to test
Open Web demo using egui and enter text to TextEdit.
if you want to try it on mobile devices please read this QR code.
This PR also support mobile text input.
I don't have macos/ios computer.please test it.