-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement From<u64> for WindowId and vise-versa #2351
Conversation
This should help downstream applications to expose WindowId to the end users via e.g. IPC to control particular windows in multi window systems.
9d39a9f
to
d5b8f0f
Compare
I'm not sure if casting to and from Windows' window handles are It also looks like X11's window IDs are always |
That's why we use
It should be, since you can't do anything with it given that |
Yeah at the very least you should be able to convert to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Android, I guess this is okay. Hopefully we can support multiple activities == multiple windows at some point.
This should help downstream applications to expose WindowId to the end
users via e.g. IPC to control particular windows in multi window
systems.
CHANGELOG.md
if knowledge of this change could be valuable to users