Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Windows, revert window background to an empty brush to avoid white flashes when changing scaling #2571

Merged
merged 1 commit into from
Nov 27, 2022
Merged

On Windows, revert window background to an empty brush to avoid white flashes when changing scaling #2571

merged 1 commit into from
Nov 27, 2022

Conversation

fgimian
Copy link
Contributor

@fgimian fgimian commented Nov 26, 2022

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

This one resolves #2570 😄

@fgimian fgimian requested a review from msiglreith as a code owner November 26, 2022 23:21
@fgimian fgimian mentioned this pull request Nov 26, 2022
Closed
msiglreith
msiglreith approved these changes Nov 27, 2022
View reviewed changes
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@msiglreith msiglreith merged commit 9ae7498 into rust-windowing:master Nov 27, 2022
@fgimian
Copy link
Contributor Author

fgimian commented Nov 27, 2022

Thanks for your help and the merge @msiglreith 😄

@fgimian fgimian deleted the avoid-white-flash-when-adjusting-scaling branch November 27, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msiglreith msiglreith

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flash of white when changing scaling on Windows (root cause included)
2 participants
@fgimian @msiglreith