Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloning on WorkerBridge #388

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

futursolo
Copy link
Collaborator

Fix #387.

This pull request removes cloning of bridges.
This is a breaking change.

If users want to share worker bridges, they can use Rc.

@ranile ranile merged commit 92510b4 into rustwasm:master Oct 9, 2023
ranile added a commit that referenced this pull request Oct 9, 2023
@ranile
Copy link
Collaborator

ranile commented Oct 9, 2023

~~Released in gloo-worker v0.4.1 🎉 ~~

That release was yanked. I accidentally released #388 as patch release but it is a breaking change. gloo-worker v0.5.0 has been released to fix it

ranile added a commit that referenced this pull request Dec 6, 2023
I accidentally released #388 as patch release but it is a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning gloo-worker bridges does not assign new HandlerIds
2 participants