Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syn to v2 #239

Merged
merged 3 commits into from
May 30, 2023
Merged

Update syn to v2 #239

merged 3 commits into from
May 30, 2023

Conversation

daxpedda
Copy link
Contributor

Updates syn to v2.

@daxpedda daxpedda marked this pull request as draft May 12, 2023 15:38
@@ -16,7 +16,7 @@ serde_json = { version = "1.0.40", features = ['preserve_order'] }
tempfile = "3.1.0"
walrus = { path = "../.." }
walrus-tests-utils = { path = "../tests-utils" }
wasmprinter = "0.2.25"
wasmprinter = "=0.2.31"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all roundtrip tests failed with any version higher then v0.2.31.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasmprinter has been updated in #243 now. I've just rebased to that.

@daxpedda daxpedda marked this pull request as ready for review May 12, 2023 16:21
@guybedford guybedford merged commit 4cfaca3 into rustwasm:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants