git: Ensure no backend ever takes an index lock #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git status
(andgit describe --dirty
) takes an optional write lock as a performance optimization: https://git-scm.com/docs/git-status#_background_refreshThis is bad because:
Both of these situations are very hard to root cause and debug.
git describe
does not currently supportGIT_OPTIONAL_LOCKS=0
(gitgitgadget/git#1872), so this reimplements the-dirty
suffix logic usinggit status
.This is not an issue for libgit2 or gix, but this includes tests for those backends in case they change their implementations.