Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for HT-A7000. #107

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Bugfixes for HT-A7000. #107

merged 2 commits into from
Feb 20, 2022

Conversation

Flameeyes
Copy link
Contributor

Trying to leverage the changes in 0.14.0 in my Home Assistant pull request, I found a couple of mistakes on my part.

There is a new "content" object in the ContentChange/PlaybackInfo.

This object only has a single documented field which is thumbnailUrl.
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍 Do you want to have a new patch release immediately, or shall we wait a bit?

@rytilahti rytilahti merged commit 2051b97 into rytilahti:master Feb 20, 2022
@Flameeyes
Copy link
Contributor Author

(Sorry for the delay in answering — you know, the world.)

If you have time to make a 0.14.1 it might be helpful because I think nobody has used this in Home Assistant yet, so we might as well avoid any noise where it might happen to cause noise in logs.

rytilahti added a commit that referenced this pull request Mar 1, 2022
[Full Changelog](0.14...0.14.1)

**Closed issues:**

- Inconsistency between `get_update_info` and `SoftwareUpdateChange` [\#93](#93)

**Merged pull requests:**

- Add pyupgade to pre-commit hooks and CI [\#110](#110) ([rytilahti](https://github.com/rytilahti))
- Drop support for python 3.6 [\#109](#109) ([rytilahti](https://github.com/rytilahti))
- Use github actions instead of azure pipelines for CI [\#108](#108) ([rytilahti](https://github.com/rytilahti))
- Bugfixes for HT-A7000. [\#107](#107) ([Flameeyes](https://github.com/Flameeyes))
@rytilahti rytilahti mentioned this pull request Mar 1, 2022
@rytilahti
Copy link
Owner

rytilahti commented Mar 1, 2022

@Flameeyes preparing the release now, stay tuned :-) edit: homeassistant PR home-assistant/core#67435

rytilahti added a commit that referenced this pull request Mar 1, 2022
This release contains fixes for HT-A7000 and drops support for EOL'd python 3.6.

[Full Changelog](0.14...0.14.1)

**Closed issues:**

- Inconsistency between `get_update_info` and `SoftwareUpdateChange` [\#93](#93)

**Merged pull requests:**

- Add pyupgade to pre-commit hooks and CI [\#110](#110) ([rytilahti](https://github.com/rytilahti))
- Drop support for python 3.6 [\#109](#109) ([rytilahti](https://github.com/rytilahti))
- Use github actions instead of azure pipelines for CI [\#108](#108) ([rytilahti](https://github.com/rytilahti))
- Bugfixes for HT-A7000. [\#107](#107) ([Flameeyes](https://github.com/Flameeyes))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants