Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on async_upnp_client >=0.27 and fix UpnpFactory imports #113

Merged
merged 4 commits into from
May 29, 2022

Conversation

yllar
Copy link
Contributor

@yllar yllar commented May 5, 2022

StevenLooman/async_upnp_client@593b72e breaks UpnpFactory imports, this should fix it

@rytilahti
Copy link
Owner

This requires bumping the required async_upnp_client version to be >=0.27. Would you please modify the pyproject.toml, run poetry update, and add the changed files to this PR?

@yllar
Copy link
Contributor Author

yllar commented May 25, 2022

Updated

@rytilahti
Copy link
Owner

Linting checks are failing (due to psf/black#2964), please run pre-commit autoupdate and commit the precommit file to fix that.

@yllar
Copy link
Contributor Author

yllar commented May 25, 2022

third time's a charm? 🤞

@rytilahti
Copy link
Owner

Looks like not yet, you can execute the same checks as the pipeline does by running pre-commit run -a locally to make sure it passes :-)

@yllar
Copy link
Contributor Author

yllar commented May 26, 2022

pre-commit run -a is happy now, let's see whats next!

@rytilahti rytilahti changed the title Fix UpnpFactory imports Depend on async_upnp_client >=0.27 and fix UpnpFactory imports May 29, 2022
@rytilahti rytilahti merged commit e3b5aa1 into rytilahti:master May 29, 2022
rytilahti added a commit that referenced this pull request Jul 13, 2022
[Full Changelog](0.14.1...0.15)

**Breaking changes:**

- Change `get_play_info` to return info from all available zones [\#114](#114) (@jwiese)

**Merged pull requests:**

- Depend on async\_upnp\_client \>=0.27 and fix UpnpFactory imports [\#113](#113) (@yllar)
- Notification listen refactor [\#112](#112) (@Flameeyes)
@rytilahti rytilahti mentioned this pull request Jul 13, 2022
rytilahti added a commit that referenced this pull request Jul 13, 2022
[Full Changelog](0.14.1...0.15)

**Breaking changes:**

- Change `get_play_info` to return info from all available zones [\#114](#114) (@jwiese)

**Merged pull requests:**

- Depend on async\_upnp\_client \>=0.27 and fix UpnpFactory imports [\#113](#113) (@yllar)
- Notification listen refactor [\#112](#112) (@Flameeyes)
rytilahti added a commit that referenced this pull request Jul 13, 2022
[Full Changelog](0.14.1...0.15)

**Breaking changes:**

- Change `get_play_info` to return info from all available zones [\#114](#114) (@jwiese)

**Merged pull requests:**

- Depend on async\_upnp\_client \>=0.27 and fix UpnpFactory imports [\#113](#113) (@yllar)
- Notification listen refactor [\#112](#112) (@Flameeyes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants