Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing mistake in get_soundfield #95

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Conversation

Flameeyes
Copy link
Contributor

This was meant to be a one line change, but pre-commit refused to let me fix it unless I also fixed mypy annotations, so here's an update of pre-commit to go with it.

This includes replacing the flake8 usage to use the right repository.
This returns a single setting, not a list.
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@rytilahti rytilahti changed the title Fix typing mistake in API. Fix typing mistake in get_soundfield Jan 4, 2022
@rytilahti rytilahti merged commit 67e436c into rytilahti:master Jan 4, 2022
@rytilahti rytilahti mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants