Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Adding scripting mode documentation to safe-docs #434

Closed
falvaradorodriguez opened this issue Jul 5, 2024 · 6 comments · Fixed by safe-global/safe-docs#571
Closed
Assignees
Labels
enhancement New feature or request

Comments

@falvaradorodriguez
Copy link
Contributor

The new options implemented in #36 need to be added to the safe-cli documentation in safe-docs.

Currently only the interactive mode is documented, and the direct commands as well as the tx-builder command need to be documented.

@falvaradorodriguez falvaradorodriguez added the enhancement New feature or request label Jul 5, 2024
@Uxio0 Uxio0 assigned falvaradorodriguez and unassigned Uxio0 Jul 12, 2024
@sebastiendan
Copy link

Hey @falvaradorodriguez, any chance I could get some guidelines for tx-builder while the doc is being worked on? I couldn't find details regarding the file that the command expects (what it should contain, etc.).

@falvaradorodriguez
Copy link
Contributor Author

Hey @falvaradorodriguez, any chance I could get some guidelines for tx-builder while the doc is being worked on? I couldn't find details regarding the file that the command expects (what it should contain, etc.).

Hi @sebastiendan, you can generate and export one of these JSON files from the Transaction Builder app on the Safe website.

Screenshot 2024-07-16 at 16 22 45

@sebastiendan
Copy link

@falvaradorodriguez So you mean the tx-builder command is not a replacement for the UI, but a complementing tool? (basically I'm looking for a way with safe-cli to create and propose a transaction, for it to be later multisig-ed in Safe Wallet)

@falvaradorodriguez
Copy link
Contributor Author

@falvaradorodriguez So you mean the tx-builder command is not a replacement for the UI, but a complementing tool? (basically I'm looking for a way with safe-cli to create and propose a transaction, for it to be later multisig-ed in Safe Wallet)

Sorry, I didn't express myself well. Yes, safe-cli replaces the interface. What I meant to say was that you could generate a JSON example from there as we don't have documentation on how to generate it at the moment.

Anyway, if you are looking to propose a transaction, this may help.

Even here shows some examples of how to directly use the commands to create and propose a transaction.

@sebastiendan
Copy link

sebastiendan commented Jul 16, 2024

@falvaradorodriguez I've run some tests, and from what I can see send-custom requires all signers (it basically propose, confirm, and execute all at once).

Edit: same for tx-builder => with a 2-out-2 multisig, I need to pass both private keys, so I cannot just propose the transaction.

@falvaradorodriguez
Copy link
Contributor Author

@sebastiendan Yes, if you are only looking to propose the transaction, for the moment, from safe-cli it's only possible to do the complete flow (as the main idea is to be a substitute for the interface).

Anyway, you could propose the transaction using the SDK from Python or Js following this example.

As this topic already differs from the initial question, if you still have doubts about this, it might be better to move the question to the appropriate channel. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants