-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add documentation for non-interactive safe-cli commands #571
docs: Add documentation for non-interactive safe-cli commands #571
Conversation
Branch preview✅ Deployed successfully in branch deployment: https://add_non_interactive_commands_safe_cli--docs.review.5afe.dev |
Overall readability score: 53.57 (🟢 +0.09)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
This PR works, but I have some remarks:
I am unsure what to do here, so I will ask @tanay1337 and @germartinez. I would say we can accept this PR and open a ticket for ourselves to improve the quality of these docs. |
Just to clarify, the guides have been moved from the "Demo" section to the "Guides" section, for share the same structure in all projects in safe-docs. But these videos already existed in the doc. |
Hey Felipe, to merge this PR, we would require to either:
We aim for consistency in the docs regarding what a guide and what a tutorial is. So we would ask you to fix this to speed up the review of this PR, or we would take it up in the next sprint. |
Hi @valle-xyz, Since this is not a trivial change, I have opted to revert the updating of the Demos section. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added minor grammarly correction. Looks good to me.
Closes safe-global/safe-cli#434
To be considered:
The demos and guides sections have been unified to follow the same format as in other documentation sections. Each demo has been integrated as a new guide.