-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signatures using the Core SDK #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall readability score: 68.54 (🔴 -0.21)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
germartinez
commented
Jan 25, 2024
Notes:
|
germartinez
commented
Jan 25, 2024
@germartinez all the suggestions and comments were addressed |
yagopv
approved these changes
Jan 31, 2024
tanay1337
suggested changes
Feb 13, 2024
tanay1337
approved these changes
Feb 13, 2024
Co-authored-by: Mikhail <16622558+mmv08@users.noreply.github.com>
Co-authored-by: Germán Martínez <6764315+germartinez@users.noreply.github.com>
Co-authored-by: Germán Martínez <6764315+germartinez@users.noreply.github.com>
Co-authored-by: Germán Martínez <6764315+germartinez@users.noreply.github.com>
Co-authored-by: Germán Martínez <6764315+germartinez@users.noreply.github.com>
Co-authored-by: Germán Martínez <6764315+germartinez@users.noreply.github.com>
Co-authored-by: Germán Martínez <6764315+germartinez@users.noreply.github.com>
Co-authored-by: Germán Martínez <6764315+germartinez@users.noreply.github.com>
Co-authored-by: Tanay Pant <7481165+tanay1337@users.noreply.github.com>
eb815d2
to
c53925f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The SDK team is updating the documentation to explain how to create signatures using the Safe{Core} SDK:
Note:
This PR cherry picks all the commits from #313 as that PR was created from the wrong base branch. This one is using
development
afternextra
was squash merged.