-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add new ERC-7579 Tutorial #589
Conversation
Branch preview✅ Deployed successfully in branch deployment: |
Overall readability score: 42.52 (🟢 +0.03)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @valle-xyz for the good work! The tutorials works as intended, so congrats on that!! 🙌 (And I know the kind of pain this means 😌). It's also much shorter, so kudos for that too, we'll be saving a lot of time to builders. 💪💪
I have noted a few improvement points:
- We should probably explain to the user when/how is the safe deployed (and display e.g. the safe address, maybe with a link to the Safe Wallet UI?)
- We could add numbers to the titles so it outlines the different steps we'll need to take (as it is for the title
1. Setup a Next.js application
- At step "Interact with the 7579 module directly", there is a typo on the third bullet point:
The transaction executes a call from your smart account call the module with the defined data.
- Except for the console.logs, there is no user feedback after clicking the buttons
I also get a couple of type errors:
- I get a type error as the object passed to
toSafeSmartAccount
should not have achain
property (at stepInitialize the clients
) - The
useState
are not typed. For example, the firstuseState
should be:
const [safeAccount, setSafeAccount] = useState<ToSafeSmartAccountReturnType<EntryPointVersion> | null>(null)
Lastly, I have wider discussion points that I believe we should tackle with the rest of the team:
- On the relevance of using OwnableExecutor, since Safes already have very similar functionality
- Using
privateKeyToAccount
brings back the problem of having to manage private keys on the client-side - Should we bring back the layout from the other tutorial apps?
Anyway congrats again on your work on this! Let's continue the conversation on Slack 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a ReferenceError: window is not defined
when running the 7559 repo. I also fixed some type errors, which should be reflected in the repo, along with the fix for window is not defined
.
We're getting there! 💪
Replaces the old 7579 tutorial with a new one.