Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra lines in property descriptions to avoid :return: expressions #683

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

louis-md
Copy link
Collaborator

@louis-md louis-md commented Jan 30, 2025

What it solves

This PR fixes a display error where some properties descriptions include type definitions, due to how they are defined in the transaction-service repo (e.g.: here).

How it solves it

To fix it, we stop displaying the lines after the first keyword (:param obj:) in the description, effectively removing the extra type definitions.

Result

Before:
Capture d’écran 2025-01-30 à 17 15 17

After:

Capture d’écran 2025-01-30 à 17 14 03

@louis-md louis-md self-assigned this Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Branch preview

✅ Deployed successfully in branch deployment:

https://fix_api_descriptions--docs.review.5afe.dev

@louis-md louis-md requested a review from tanay1337 January 30, 2025 16:26
@louis-md louis-md merged commit 6377367 into main Jan 31, 2025
3 of 4 checks passed
@louis-md louis-md deleted the fix-api-descriptions branch January 31, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants