Minor windows fix #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @peakschris to sign the Salesforce Inc. Contributor License Agreement. |
guw
reviewed
Aug 2, 2024
| # suggested in https://github.com/bazelbuild/rules_jvm_external/issues/445 | ||
| startup --noautodetect_server_javabase | ||
| common --repo_env=JAVA_HOME=../bazel_tools/jdk | ||
| common --action_env=JAVA_HOME=../bazel_tools/jdk |
There was a problem hiding this comment.
This seems to be environment specific, which should go into your .bazelrc-local file.
guw
reviewed
Aug 2, 2024
| @@ -26,7 +26,7 @@ __pycache__/ | |||
| *.zip | |||
| *.tar.gz | |||
| *.rar | |||
| *.jar | |||
| #*.jar | |||
There was a problem hiding this comment.
We intentionally do not want to commit the jar. It's generated as part of CI.
guw
reviewed
Aug 2, 2024
| if (!absoluteFilePath.startsWith(workDir)) { | ||
| String filePath = first.get().toString(); | ||
| throw new IOException( | ||
| String.format("Unable to confirm working dir '%s' using file '%s' with absolute path '%s'!", | ||
| String.format("Unable to confirma working dir '%s' using file '%s' with absolute path '%s'!", |
|
This looks like an accidental pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharing for communication only. If this is desired, will remove the jar etc.