Use latest TypeScript version (#423)

* bump typescript version and other deps * linter fixes due to better type inference * use latest eslint * downgrade eslint npm i doesn't complain but npm ci does :\ * regenerate docs
salesforce · Jun 24, 2024 · e485f17 · e485f17
1 parent da21d8f
commit e485f17
Show file tree

Hide file tree

Showing 4 changed files with 336 additions and 325 deletions.
diff --git a/api/tough-cookie.api.md b/api/tough-cookie.api.md
@@ -4,8 +4,6 @@
 
 ```ts
 
-/// <reference types="node" />
-
 // @public
 export interface Callback<T> {
     // (undocumented)

diff --git a/lib/cookie/cookieJar.ts b/lib/cookie/cookieJar.ts
@@ -916,7 +916,7 @@ export class CookieJar {
         cookies = cookies.filter(matchingCookie)
 
         // sorting of S5.4 part 2
-        if (options && 'sort' in options && options.sort !== false) {
+        if ('sort' in options && options.sort !== false) {
           cookies = cookies.sort(cookieCompare)
         }
 
@@ -1474,7 +1474,7 @@ export class CookieJar {
 
         completedCount++
 
-        if (completedCount === cookies?.length) {
+        if (completedCount === cookies.length) {
           if (removeErrors[0]) cb(removeErrors[0])
           else cb(null, undefined)
           return