Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a series of changes across multiple files to standardize the usage of the
value
property instead ofdata
in result objects. The most important changes involve updates to various schema composers, type definitions, and test files.Schema Composers:
src/composers/HttpLlmApplicationComposer.ts
: Changedresult.data
toresult.value
in the return statement.src/composers/llm/ChatGptSchemaComposer.ts
: Replacedresult.data
withresult.value
and updated all references accordingly. [1] [2]src/composers/llm/GeminiSchemaComposer.ts
: Updated schema assignment fromentity.data
toentity.value
. [1] [2]src/composers/llm/LlmParametersComposer.ts
: Changed checks and return values fromentity.data
toentity.value
.src/composers/llm/LlmSchemaV3Composer.ts
: Modified to useresult.value
instead ofresult.data
throughout the file. [1] [2] [3]src/composers/llm/LlmSchemaV3_1Composer.ts
: Replacedresult.data
withresult.value
and updated all references accordingly. [1] [2] [3] [4] [5] [6] [7]Type Definitions:
src/typings/IResult.ts
: Changed theISuccess
interface to usevalue
instead ofdata
.Utility Functions:
src/utils/internal/OpenApiTypeCheckerBase.ts
: Updated the return value fromresult.data
toresult.value
. [1] [2]Tests:
result.value
instead ofresult.data
in assertions and return values. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]These changes ensure consistency and clarity in how result objects are handled across the codebase.The property
data
is not proper for theTry<T, E>
function;'s return value.