Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Negative Total Values in History Bundles Generated #2357

Closed
alexanderkiel opened this issue Jan 29, 2025 · 0 comments · Fixed by #2375
Closed

Fix Negative Total Values in History Bundles Generated #2357

alexanderkiel opened this issue Jan 29, 2025 · 0 comments · Fixed by #2375
Assignees
@alexanderkiel
Labels
bug Something isn't working module:interaction
Milestone
v0.32.0

Comments

@alexanderkiel
Copy link
Member

The FHIR data type of Bundle.total is unsignedInt with a specified range of 0..2,147,483,647. For that reason I convert the perfectly fine history count, which is a 64-bit long, into an 32-bit integer via blaze.fhir.spec.type/->UnsignedInt while generating the Bundle resource. If the history count is over 2,147,483,647, the integer conversion will overflow the value and possibly return a negative one.

We will just ignore there FHIR spec here and output the correct long value.
@alexanderkiel alexanderkiel added this to the v0.32.0 milestone Feb 3, 2025
@alexanderkiel alexanderkiel self-assigned this Feb 3, 2025
@alexanderkiel alexanderkiel added bug Something isn't working module:interaction labels Feb 4, 2025
alexanderkiel added a commit that referenced this issue Feb 4, 2025
@alexanderkiel
Fix Negative Total Values in History Bundles Generated
122e42e 
Closes: #2357
@alexanderkiel alexanderkiel mentioned this issue Feb 4, 2025
Merged
@alexanderkiel alexanderkiel linked a pull request Feb 4, 2025 that will close this issue
Fix Negative Total Values in History Bundles Generated #2375
Merged
alexanderkiel added a commit that referenced this issue Feb 5, 2025
@alexanderkiel
Fix Negative Total Values in History Bundles Generated
9608721 
Closes: #2357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderkiel alexanderkiel

Labels
bug Something isn't working module:interaction
Projects
None yet
Milestone
v0.32.0
Development

Successfully merging a pull request may close this issue.

Fix Negative Total Values in History Bundles Generated samply/blaze
1 participant
@alexanderkiel