Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Error Response on Invalid Value in FHIR Search #563

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

alexanderkiel
Copy link
Member

In the default lenient handling, invalid search values were ignored. This is not the intended behaviour. Only unknown search parameters should be ignored, but not invalid values.

@alexanderkiel alexanderkiel self-assigned this Dec 10, 2021
@alexanderkiel alexanderkiel added the bug Something isn't working label Dec 10, 2021
@alexanderkiel alexanderkiel added this to the v0.14.2 milestone Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #563 (40b6279) into develop (8d265e1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #563      +/-   ##
===========================================
+ Coverage    92.41%   92.43%   +0.01%     
===========================================
  Files          229      229              
  Lines        13599    13599              
  Branches       407      407              
===========================================
+ Hits         12568    12570       +2     
+ Misses         624      622       -2     
  Partials       407      407              
Impacted Files Coverage Δ
modules/db/src/blaze/db/node.clj 96.49% <100.00%> (+0.43%) ⬆️
.../interaction/src/blaze/interaction/search_type.clj 97.45% <100.00%> (ø)
modules/db/src/blaze/db/impl/batch_db.clj 84.92% <0.00%> (+0.79%) ⬆️

In the default lenient handling, invalid search values were ignored.
This is not the intended behaviour. Only unknown search parameters
should be ignored, but not invalid values.
@alexanderkiel alexanderkiel merged commit af4fd6b into develop Dec 10, 2021
@alexanderkiel alexanderkiel deleted the invalid-date-time branch December 10, 2021 13:01
@alexanderkiel alexanderkiel modified the milestones: v0.14.2, v0.15 Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant