Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bare Polymorph JSON Properties #772

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

alexanderkiel
Copy link
Member

The example is a Task resource were the output value is given as with the bare "value" key instead of one of the concrete keys like "valueReference". Such properties can't be assigned a type and have to be removed.

@alexanderkiel alexanderkiel self-assigned this Jul 21, 2022
@alexanderkiel alexanderkiel added the bug Something isn't working label Jul 21, 2022
@alexanderkiel alexanderkiel added this to the v0.18 milestone Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #772 (ce6b4ac) into develop (188b83c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #772   +/-   ##
========================================
  Coverage    93.70%   93.70%           
========================================
  Files          234      234           
  Lines        14426    14426           
  Branches       390      390           
========================================
  Hits         13518    13518           
  Misses         518      518           
  Partials       390      390           
Impacted Files Coverage Δ
...odules/fhir-structure/src/blaze/fhir/spec/impl.clj 95.89% <100.00%> (ø)

The example is a Task resource were the output value is given as with
the bare "value" key instead of one of the concrete keys like
"valueReference". Such properties can't be assigned a type and have to
be removed.
@alexanderkiel alexanderkiel force-pushed the remove-bar-properties branch from af72323 to ce6b4ac Compare July 21, 2022 16:13
@alexanderkiel alexanderkiel modified the milestones: v0.18, v0.17.12 Jul 21, 2022
@alexanderkiel alexanderkiel merged commit 909d040 into develop Jul 21, 2022
@alexanderkiel alexanderkiel deleted the remove-bar-properties branch July 21, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:fhir-structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant