Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Evaluate Measure Timeout #888

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

alexanderkiel
Copy link
Member

The environment variable FHIR_OPERATION_EVALUATE_MEASURE_TIMEOUT can be used to set a evaluate measure timeout in milliseconds. The default value will be 1 hour in order to prevent overly long evaluations from slowing down Blaze. At the same time the default should not change the behaviour of normal evaluations.

@alexanderkiel alexanderkiel force-pushed the evaluate-measure-timeout branch from 57913b5 to 084d65a Compare January 25, 2023 18:30
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #888 (f40de05) into develop (0619211) will increase coverage by 0.01%.
The diff coverage is 96.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #888      +/-   ##
===========================================
+ Coverage    94.03%   94.04%   +0.01%     
===========================================
  Files          235      235              
  Lines        14763    14786      +23     
  Branches       377      376       -1     
===========================================
+ Hits         13882    13906      +24     
  Misses         504      504              
+ Partials       377      376       -1     
Impacted Files Coverage Δ
...sure/src/blaze/fhir/operation/evaluate_measure.clj 94.25% <80.00%> (+0.27%) ⬆️
.../src/blaze/fhir/operation/evaluate_measure/cql.clj 99.55% <100.00%> (+0.02%) ⬆️
.../blaze/fhir/operation/evaluate_measure/measure.clj 95.52% <100.00%> (+0.09%) ⬆️
...src/blaze/fhir/operation/evaluate_measure/spec.clj 100.00% <100.00%> (ø)
.../operation/evaluate_measure/measure/population.clj 100.00% <0.00%> (+5.88%) ⬆️

Copy link
Member

@lablans lablans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just checked the documentation.

@alexanderkiel alexanderkiel force-pushed the evaluate-measure-timeout branch 3 times, most recently from ffc4780 to 29ab5f0 Compare January 26, 2023 13:32
The environment variable FHIR_OPERATION_EVALUATE_MEASURE_TIMEOUT can be
used to set a evaluate measure timeout in milliseconds. The default
value will be 1 hour in order to prevent overly long evaluations from
slowing down Blaze. At the same time the default should not change the
behaviour of normal evaluations.
@alexanderkiel alexanderkiel force-pushed the evaluate-measure-timeout branch from 29ab5f0 to f40de05 Compare January 26, 2023 14:57
@alexanderkiel alexanderkiel merged commit 750a64d into develop Jan 26, 2023
@alexanderkiel alexanderkiel deleted the evaluate-measure-timeout branch January 26, 2023 15:45
@alexanderkiel alexanderkiel added this to the v0.19 milestone Jan 26, 2023
@alexanderkiel alexanderkiel added enhancement New feature or request module:evaluate-measure operation Operational issues like monitoring and maintenance. labels Jan 26, 2023
@alexanderkiel alexanderkiel self-assigned this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:evaluate-measure operation Operational issues like monitoring and maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants