Add updated fuzzy search to benchmark #1
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I benchmarked the v2 search with and without the short query optimization and as I was sorta expecting it didn't make a huge difference but it was slightly faster without sqo for the queries you had in the test:
Compared to the v1 Levenshtein distance approach, the top results were:
1 and 3 both used string length as tie breakers, 2 is debatable which should be the higher score but both are relevant. I also noticed that while on my older arch laptop the highlights were fine, on my windows and macbook the highlight was increasingly off presumably as scaling increases so I think the highlighting is missing accounting for something:
So I think the remaining things to do are