add contexts to the flexible metadata model. #6915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…admin sets and then apply the contexts to the works made with that admin set selected
laritakr
reviewed
Oct 8, 2024
laritakr
reviewed
Oct 8, 2024
...tors/hyrax/templates/db/migrate/20240606205216_add_contexts_to_hyrax_flexible_schemas.rb.erb
Show resolved
Hide resolved
laritakr
reviewed
Oct 8, 2024
laritakr
reviewed
Oct 8, 2024
| @@ -18,6 +18,8 @@ classes: | |||
| contexts: | |||
| flexible_context: | |||
| display_label: Flexible Metadata Example | |||
| special_context: | |||
There was a problem hiding this comment.
Corresponding changes to this profile should probably also be made in the .koppie (and possibly .dassie?) versions, as well as the spec version.
laritakr
reviewed
Oct 8, 2024
laritakr
requested changes
Oct 8, 2024
There was a problem hiding this comment.
A few comments in addition to the above...
- the M3 profiles in specs, .koppie, and .dassie do not match the changes in the config profile. These need to be updated
- no specs exist for the code changes here
- the migration needs to also be added to koppie & dassie
- Admin set show page should display the selected metadata context if there is one
- I was unable to save a work with the dimensions term
This is the error I got trying to save the work using the context term. I'm not certain of the cause (my app crashed badly and I had to rebuild everything), but it originates on this line and the actual failure is when it calls definitions in the m3_schema_loader.
Co-authored-by: LaRita Robinson <laritakr@users.noreply.github.com>
Co-authored-by: LaRita Robinson <laritakr@users.noreply.github.com>
…/hyrax into context_feature_for_flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they can be assigned on admin sets and then apply the contexts to the works made with that admin set selected