Fixing issues where Hyrax::FileSet resources are incorrectly cast to AF ::FileSet #7038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7001
In the dassie test app, the value of
Hyrax.config.file
is set to be::FileSet
. This unintentionally causes all FileSets to be force-cast back to a ActiveFedora FileSet in theFileSetsController
, even if they should be a ValkyrieHyrax::FileSet
resource. That's because the class name passed toload_and_authorize_resource
uses that config value.The value of
Hyrax.config.file
needs to be left at::FileSet
for AF models to work, so this PR adds a conditional check in abefore_action
to see if it should cast a FileSet back with.valkyrie_resource
. Otherwise, nothing in the FileSetsController will work (i.e. versions, etc.)