Update sandstorm-app-market to Meteor v 2.3.5 #143
Conversation
… and all the files to modules with import and expoert statements, since I don't know how else to do it.
…uild, so the replalcement, faker-js/faker has not been added.
…e. This module tries to adapt those changes for the purpopses of the App Market.
… to it. Also, adding default objects appears to work differently now in SimpleSchema, so a modification for the sake of adding a ratings object to each app was made.
…early was meant to be optional.
…pMarket object is defined in /imports/lib/appMarket.js and extended in /client/lib/appMarket.js When we switched to using modules this became a bit awkward and required two imports.
There was a problem hiding this comment.
I am seeing Meteor 2.7.3 here, not 2.3.5. This may mean Kenton will need to migrate the Mongo database somehow when deploying this update, but it wouldn't present the same level of a problem as updating Sandstorm itself, considering we aren't auto-updating this code out to other people's servers.
|
Crap. I just checked and you are correct. Ergh, I don't know how that happened, I thought I was super careful to specify 2.3.5 Garrr. |
|
I'm checking now if I can just change the meteor version with |
|
Ok, I just pushed a change that makes this use Meteor 2.5.3 Which I had intended to do all along. I'm not really sure what happened, but things did get kind of hairy there with what might well have been the sabotage of the faker package. I have built with these changes and it runs. |
|
I feel like an awful person, but s/2.5.3/2.3.5 if you're trying to meet Sandstorm's version. That being said, it may be worth just asking @kentonv what he'd like to release. As it stands our app market is nearly a static site now and I'm unsure how much the Meteor version actually affects the final product on apps.sandstorm.io. But I'm really glad to see work on this because I want to try doing some app market stuff and I often get lost in bitrot. |
|
Well, I'm not normally dyslexic, but I guess it can land on anyone. I'll be happy to change it, but I'm also willing to wait for @kentonv to say he needs it. |
|
So... Believe it or not, apps.sandstorm.io today is being served as a totally static web site. There is no Meteor server nor any MongoDB running behind it. I was able to pull that off because the only features that needed the server and database were the ratings and reviews... I just removed those. The actual app database is read directly from app-index.sandstorm.io, which is technically also static content (updated whenever a new app is published). I specifically did this so I could get away with never touching it again. :) No server means no possibility of security issues. I appreciate the intent to help here, and I'm fine with merging this to help anyone else who wants to run their own app store instances, but I'm inclined not to touch the official store deployment, just on the "if it ain't broke don't fix it" principle. :) @ocdtrekkie Please feel free to take ownership of this repo and merge changes as you see fit. |
|
This is where I removed the need for a server BTW: 784906c |
|
I guess that means we can safely go with the 2.7.3 flavor, @gischer, since there's no longer a production Mongo database to worry about here. |
|
This makes all kinds of sense, give certain headaches I’ve recently been
forced into by changes in Meteor.
Nevertheless, I think that in some unspecified future, I will probably
fork the App Market and make it into a Sandstorm app.
------ Original Message ------
From: "Jacob Weisz" ***@***.***>
To: "sandstorm-io/sandstorm-app-market"
***@***.***>
Cc: "gischer" ***@***.***>; "Mention" ***@***.***>
Sent: 11/12/2022 9:06:18 AM
Subject: Re: [sandstorm-io/sandstorm-app-market] Update
sandstorm-app-market to Meteor v 2.3.5 (PR #143)
I guess that means we can safely go with the 2.7.3 flavor, @gischer
<https://github.com/gischer>, since there's no longer a production
Mongo database to worry about here.
—
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM6NXE74SVF43WSOJQ7KCLWH7FAVANCNFSM6AAAAAAQAUBKII>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
… |
|
@gischer Depending on your needs/goals, I think it'd be ideal to transition the official app store to that model some day as well, if you'd like to work within the official repo here, we probably could accommodate that. Considering that the official market now operates as a static site, presumably it could be replaced by a Sandstorm app using the static web publishing feature. |
While doing this I also:
make-bundle.shthat will add the above packages via themeteor npmsubcommand. I also add the @babel/runtime this way. It seems required these days.This isn't a small change, and I'm not entirely certain you'll want them. I have a burning need for at least this much, though, so I will probably keep using this fork, and you are welcome to them if you want them.
I endorse the idea of converting this app to be a Sandstorm app, by the way, but that seemed way too much for a PR, and not something I would have the time for right now, either.