Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sanity): fix potential initial value resolution deopt #9014

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Mar 21, 2025

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:55pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:55pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:55pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 21, 2025 2:55pm
test-next-studio ⬜️ Ignored (Inspect) Mar 21, 2025 2:55pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 21 Mar 2025 15:03:01 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.7 efps (44ms) 24.4 efps (41ms) -3ms (-6.8%)
article (body) 75.5 efps (13ms) 69.7 efps (14ms) +1ms (-/-%)
article (string inside object) 26.3 efps (38ms) 24.4 efps (41ms) +3ms (+7.9%)
article (string inside array) 22.2 efps (45ms) 21.7 efps (46ms) +1ms (+2.2%)
recipe (name) 45.5 efps (22ms) 45.5 efps (22ms) +0ms (-/-%)
recipe (description) 47.6 efps (21ms) 50.0 efps (20ms) -1ms (-4.8%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.9 efps (53ms) 19.6 efps (51ms) -2ms (-3.8%)
synthetic (string inside object) 19.0 efps (53ms) 19.6 efps (51ms) -2ms (-2.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 77ms 94ms 369ms 703ms 12.5s
article (body) 13ms 15ms 17ms 115ms 168ms 5.0s
article (string inside object) 38ms 40ms 43ms 49ms 40ms 6.5s
article (string inside array) 45ms 48ms 50ms 76ms 343ms 7.3s
recipe (name) 22ms 24ms 27ms 52ms 0ms 7.1s
recipe (description) 21ms 22ms 24ms 24ms 0ms 4.8s
recipe (instructions) 5ms 7ms 8ms 42ms 3ms 3.3s
synthetic (title) 53ms 56ms 66ms 321ms 863ms 12.8s
synthetic (string inside object) 53ms 55ms 58ms 240ms 917ms 8.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 48ms 67ms 359ms 670ms 11.3s
article (body) 14ms 16ms 18ms 141ms 153ms 5.2s
article (string inside object) 41ms 42ms 45ms 136ms 195ms 6.9s
article (string inside array) 46ms 47ms 53ms 64ms 169ms 7.1s
recipe (name) 22ms 24ms 26ms 32ms 0ms 7.2s
recipe (description) 20ms 22ms 23ms 39ms 0ms 4.8s
recipe (instructions) 5ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 51ms 55ms 64ms 171ms 847ms 15.5s
synthetic (string inside object) 51ms 54ms 62ms 376ms 1145ms 8.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant