-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(preview): fix issue with document version indicators not syncing #9040
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
No changes to documentation |
Coverage Report
File Coverage
|
⚡️ Editor Performance ReportUpdated Mon, 24 Mar 2025 20:33:23 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
📊 Playwright Test ReportThis report contains test results, including videos of failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bjoerge, tested all the cases I could think and this works great.
Description
Currently, the version indicator dots in previews doesn't properly update after a version is created or deleted (i.e. when a document is published, a draft or version is is created or discarded)
This PR fixes it, as seen here:
Screen.Recording.2025-03-24.at.21.08.35.mov
Also added a small util for checking whether a document id matches a provided perspective stack. This is marked as @internal, but exported from the package for consistency with other functions in
draftUtils
Additionally made some small tweaks to comments to make it a bit clearer (I hope!)
What to review
Does it make sense?
Testing
Notes for release