unfork specs2 #333
Merged
unfork specs2 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
argh we need to fork lift-json to depend on "specs2-core" instead of "specs2". well, better to have forked lift-json than forked specs2. |
|
new test run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/758/consoleFull (404 til Jenkins catches up) |
SethTisue
force-pushed
the
unfork-specs2
branch
from
ebf4d37 to
08a0df7
Compare
the reason we'd forked had to do with scalamock but we've addressed the issue there instead fixes scala#157
SethTisue
force-pushed
the
unfork-specs2
branch
from
08a0df7 to
5bfc38a
Compare
but at least the fork is newer than the old frozen ref we were depending on before, so yay
SethTisue
force-pushed
the
unfork-specs2
branch
from
5bfc38a to
e7df53d
Compare
|
(the spire change is unrelated, but it was getting in my way when trying to test this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason we'd forked had to do with scalamock but we've addressed
the issue there instead
fixes #157