Do not merge throwable to itself #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroKr21
approved these changes
Nov 28, 2021
Comment on lines
+32
to
+37
| def mkPool(name: String) = { | ||
| val parallelism = 1 | ||
| val handler: Thread.UncaughtExceptionHandler = null | ||
| val asyncMode = false | ||
| new ForkJoinPool(parallelism, mkFactory(name), handler, asyncMode) | ||
| } |
There was a problem hiding this comment.
Is this because we can't use named arguments for Java-defined methods? 🤔
There was a problem hiding this comment.
Yes, I believe scalac still complains, although I didn't try again here. Fool me once, as the saying goes.
I actually did this because my first version of the test was this plus throwing on run, but that fails outright and hangs!
| @@ -48,4 +53,43 @@ class TaskTest { | |||
| val r = c.filter(_ != 0).map(_ + 1) | |||
| assertSame(myTs, r.tasksupport) | |||
| } | |||
|
|
|||
| // was: Wrong exception: expected scala.collection.parallel.TaskTest$SpecialControl$1 but was java.lang.IllegalArgumentException | |||
There was a problem hiding this comment.
Before the fix, the assertThrows fails with this message.
|
Thank you all! |
|
Shall I roll a release, or should we wait and see if any other fixes accumulate? |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Jan 17, 2025
### What changes were proposed in this pull request? This pr aims to upgrade `scala-parallel-collections` from 1.0.4 to 1.2.0 ### Why are the changes needed? The new version includes a bug fix for exception merging: - scala/scala-parallel-collections#205 The full release notes as follows: - https://github.com/scala/scala-parallel-collections/releases/tag/v1.1.0 - https://github.com/scala/scala-parallel-collections/releases/tag/v1.2.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #49548 from LuciferYang/SPARK-50871. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Jan 17, 2025
### What changes were proposed in this pull request? This pr aims to upgrade `scala-parallel-collections` from 1.0.4 to 1.2.0 ### Why are the changes needed? The new version includes a bug fix for exception merging: - scala/scala-parallel-collections#205 The full release notes as follows: - https://github.com/scala/scala-parallel-collections/releases/tag/v1.1.0 - https://github.com/scala/scala-parallel-collections/releases/tag/v1.2.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #49548 from LuciferYang/SPARK-50871. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4e47023) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scala/bug#10276
Original issue was OOM, thanks @joroKr21 for suggestion to throw a cached value. Fix by @oxbowlakes