Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20211 #20220

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix #20211 #20220

merged 1 commit into from
Apr 18, 2024

Conversation

hamzaremmal
Copy link
Member

I'm not sure yet if this is the best was to fix it as it is in contradiction with #20188

/cc @nicolasstucki

@hamzaremmal hamzaremmal requested a review from odersky April 18, 2024 12:00
@hamzaremmal hamzaremmal linked an issue Apr 18, 2024 that may be closed by this pull request
@hamzaremmal
Copy link
Member Author

We should also capture the output (and error) streams and not display them in the logs of vulpix

@hamzaremmal hamzaremmal merged commit 99c19a7 into scala:main Apr 18, 2024
19 checks passed
@hamzaremmal hamzaremmal deleted the i20211 branch April 18, 2024 22:36
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
WojciechMazur added a commit that referenced this pull request Jul 6, 2024
Backports #20220 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulpix will print a compiler crash when it shouldn't
4 participants