rename Session to make import collisions less likely #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Jun 10, 2020
|
I triggered a 2.2.2 release so this fix should be publicly available soon |
|
Brilliant, thanks! |
|
It looks like Sonatype timed out, could you re-run that action when you have a sec? |
|
The release succeeded after a retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
repl.Sessionis in scope it ends up being impossible to import another symbol calledSession, which makes it impossible to build the Skunk doc because the central abstraction is calledSession;-)So this renames it to
repl.MdocSessionto make collisions less likely.