Add jest & mocha eslint plugins

[francoisferrand]

• Add jest & mocha eslint plugins
• Fix eslint to properly detect brace-less one-line if

Issue: GDL-10

[bert-e]

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue GDL-10 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.3.1

Please check the Fix Version/s of GDL-10, or the target
branch of this pull request.

[francoisferrand]

need to be added to dependencies (and/or peerDependencies?) for the plugins to be automatically added to the "top-level" node_modules, and thus available when running eslint...

[BourgoisMickael]

as we don't need both, they should go in peerDependencies and eslint should go there too

[francoisferrand]

if we don't add it to dependencies, these plugins will not be included when depending on this plugin (in the "user" package, like cloudserver/...), as peer dependencies do not get installed (just display a warning) : and thus will have more dependencies to include in every package...

The peerDependencies is not really needed here, what I really want is a dependency : and peerDependency may be added simply to avoid having duplicating versions of the dependency...

[BourgoisMickael]

But that's the point that we don't want to automatically add it by default, it should be the source repo that picks if it wants to install the plugin jest or mocha based on what it needs to avoid unnecessary dependency.

But maybe they are small enough to ignore an extra unused dependency.

[francoisferrand]

Maybe too strong, causes lots of errors...
→ just "mocha/no-exclusive-tests" and "jest/no-focused-tests" ?
→ or extend recomended plugins, then disable a few (no arrow...)?