Templating + Fixes for Static and PDF Generation #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When printing the CSS file paths need to be rewritten to match the absolute URIs used in PDFKit. In addition, it is required to configure the print media style or the output will be buggy. In print mode, the position of the slide needs to be set explicitly to "relavtive" or more explict styling in the slide container will fail in print mode.
* fixing positioning of a slide when using the onepage.css
Replaced the ###CONTENT### string with something that does not break in Markdown :). Furthermore now multiple replacements can be used in the slides, the documentation is in the README.
Closed
|
I merged the recent changes from schacon/master to keep the changes compatible with the current development. |
|
Hey, this is just what I was looking for! I hope this gets merged in soon. |
|
I love this change. I'm not so sure about the ~~~ SYNTAX ~~~, but I don't have a better suggestion either. I'll merge this and tweak the README a little bit. This is an advanced feature and I believe it's introduced too soon. |
goncalossilva
added a commit
that referenced
this pull request
Mar 5, 2012
Templating + Fixes for Static and PDF Generation
goncalossilva
added a commit
that referenced
this pull request
Mar 5, 2012
goncalossilva
added a commit
that referenced
this pull request
Mar 6, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
basically this group of commits does a few things.
First, it implements a way to provide the user with layout templates if he wants and make the pretty configurable . Templates can be applied either per default or per slide. Please have a look at the updated readme for a usage instruction.
Second, I fixed a a few bugs that relate to static HTML and PDF generation. This includes, rewriting URLs used in CSS to point to static file:// URIs, forcing wkthmltopdf to use the print media styles instead of the screen media styles. In addition sytnax highlighting now works both in PDF and static mode.
It would be great if you could review my changes.
You can find a simple presentation of how to use the templates, made with showoff here - http://grundprinzip.github.com/Showoff-Templates
Thanks
Martin