Release v.2.5.0 #610
Merged
Release v.2.5.0 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s- Helge Zoellner Added opts field Order to the struct to manually overwrite the sub-spectra order. For MEGA this is a single number indicating whether the order is switched. Osprey convention is edit OFF first. For HERMES/HERCULES it is a 4 entry vector indicating the index at which the spectra A,B,C, and D are acquired, e.g.: GABA-OFF GSH-OFF A GABA-ON GSH-OFF B GABA-OFF GSH-ON C GABA-ON GSH-ON D
[FEATURE REQUEST] -Manually overwrite subspectra order - OspreyProces…
Improved the XA30 support for Osprey including proper version flags for XA30 and identification of the subspectra dimension for the Siemens WIP.
[FEATURE] - XA30 loader Siemens WIP MEGA - load_twix - gunziyhu
JSON jobfile resulted in a cell of cells instead of a cell array for user defined metabolite lists. Fixed during the read-out of the JSON file in OspreyJob.
…y Stennett" This reverts commit d14982e.
GUI created job resulted in cell of cells instead of a cell array. Fixed during the JSON read out in OspreyJob
[BUG] - GUI crash for user defined metabs- OspreyJob - Bethany Stennett
…ySeg - Stella Hadfield Elliot This bug was related to the fact that DCM files have no filename during the fileparts generation of the file input. Therefore, they were always flagged as SameName files. However, without a filename the OspreySeg output resulted in similar file names for all datasets. This has now been fixed for OspreyCoreg and OspreySeg.
[BUG FIX] - Segmentation fails for DCM spec files - OspreyCoreg Ospre…
- Added a drawnow statement to iniOverview to avoid GUI crashes - Added reference to first nDatasets dimension in OspreyOverview - Renamed T1w image in the MEGA-PRESS SDAT files to match BIDS standard
Minor Bug fixes in various functions
- Added cosmetic zoom and exponential linebroadening options to the OspreyFit plot. Default values in the GUI are 0 Hz lb and a zoom factor of 2.75. These values can be changed with the sliders in the GUI. - Cosmetic parameters can also be added in the container file via: MRSCont.opts.cosmetics.LB = 0 and MRSCont.opts,cosmetics.Zoom = 2.75
[FEATURE] - Add visual LB and Zoom - plot_OspreyFit - Richard Edden
Added the lb functions to the ParamToModel function.
[FEATURE] - Add visual LB and Zoom - plot_OspreyFit - Richard Edden
This includes several adaptions to prepare the Osprey Standalone version. Including automated deployment routines in the code and separation of basis set files and code. Also thanks to Paul Mullins and Billy Hayes for figuring out to bugs related to the json file.
[FEATURE] - Adaptions for Compilation
Added options for windows compilation
Prepare windwos compilation
Removed the redundant specs entries and the ppm-axis from the basis set .mat files to reduce the file size. The entries will be recalculated during initialization step.
Reduce basisset filesize
- Bug fix for DICOM without water reference - added some flags to include ChangeTab at later timepoints of the GUI call
Some more prep for compialtion
…zhao - Added better read in capabilities to the LCModel .basis file to account for highly unstandardized formatting.
[BUG FIX] - Can not import basis set form LCModel correctly - shaokun…
…ortParams Resetting the repo.
…b file examples, and put the function call at the end of OspreyOverview.
…b file examples, and put the function call at the end of OspreyOverview.
- Added all possible naming combinations for Osprey legacy code
Finalizing osp_exportParams
- CI caught missing end statements in the latest pull request
BUG FIX - Missing End in OspreyJob
CI caught another syntax error in OspreyOverview
BUG OspreyOverview
- CI caught another syntax error in the latest version of OspreyOverview
BUG OspreyOverview
export parameters were not correctly set if .m file is used as input jobfile. Again caught by CI
BUG OspreyJob .m defaults
Hopefully the final change for the export parameter function
BUG default options .m file
… Peter Allen - the metabolite name list had a different length than expected for the supplied basis set
[BUG FIX] - OspreyQuanitfy crash for limited basis - OspreyQuantify -…
- The field names for the resampled basis set were always parsed from the metabolite file. This has now been fixed during the memory optimization and the GUI calls.
[BUG FIX] - Unrecognized field in basis set - OspreyFit - Mingrun Shi
- update version number and release date
Preparation release v.2.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get all changes into master branch for next Osprey release