Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cython 3 #792

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Add support for Cython 3 #792

merged 4 commits into from
Feb 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 19, 2024

Just by adding some noexcept

Fixes #790 @bremner

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (ea15747) 61.68% compared to head (42ae539) 52.70%.

Files Patch % Lines
src/pyscipopt/conshdlr.pxi 0.00% 22 Missing ⚠️
src/pyscipopt/benders.pxi 0.00% 14 Missing ⚠️
src/pyscipopt/branchrule.pxi 0.00% 9 Missing ⚠️
src/pyscipopt/event.pxi 0.00% 9 Missing ⚠️
src/pyscipopt/nodesel.pxi 0.00% 8 Missing ⚠️
src/pyscipopt/pricer.pxi 0.00% 8 Missing ⚠️
src/pyscipopt/sepa.pxi 0.00% 8 Missing ⚠️
src/pyscipopt/benderscut.pxi 0.00% 7 Missing ⚠️
src/pyscipopt/heuristic.pxi 0.00% 7 Missing ⚠️
src/pyscipopt/relax.pxi 0.00% 7 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
- Coverage   61.68%   52.70%   -8.99%     
==========================================
  Files          16       16              
  Lines        3255     3808     +553     
==========================================
- Hits         2008     2007       -1     
- Misses       1247     1801     +554     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mkoeppe added a commit to mkoeppe/sage that referenced this pull request Feb 19, 2024
@leoneifler
Copy link

Thank you for updating this. Just needs a one-line CHANGELOG entry, looks ready to merge otherwise 👍

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 19, 2024

Note that I have not removed the version constraint, so when build isolation is in use, it continues to use Cython 0.29.x.
If you want me to change this in this PR, let me know

@leoneifler
Copy link

leoneifler commented Feb 20, 2024

Note that I have not removed the version constraint, so when build isolation is in use, it continues to use Cython 0.29.x. If you want me to change this in this PR, let me know

Good point. I think since it is now supported, it makes sense to raise the version requirement, as well. Or is there any reason against this that I am not seeing?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2024

is there any reason against this that I am not seeing?

Not really, but I haven't tested anything other than that it compiles.

@mmghannam
Copy link
Member

Thanks @mkoeppe for your contribution! For some reason the code coverage tool seems to be unhappy with this although the lines changes were not covered before. But it looks good to me!

@mmghannam mmghannam merged commit e838781 into scipopt:master Feb 25, 2024
1 of 3 checks passed
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"python setup.py build" fails
4 participants