-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cython 3 #792
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #792 +/- ##
==========================================
- Coverage 61.68% 52.70% -8.99%
==========================================
Files 16 16
Lines 3255 3808 +553
==========================================
- Hits 2008 2007 -1
- Misses 1247 1801 +554 ☔ View full report in Codecov by Sentry. |
Thank you for updating this. Just needs a one-line CHANGELOG entry, looks ready to merge otherwise 👍 |
Note that I have not removed the version constraint, so when build isolation is in use, it continues to use Cython 0.29.x. |
Good point. I think since it is now supported, it makes sense to raise the version requirement, as well. Or is there any reason against this that I am not seeing? |
Not really, but I haven't tested anything other than that it compiles. |
Thanks @mkoeppe for your contribution! For some reason the code coverage tool seems to be unhappy with this although the lines changes were not covered before. But it looks good to me! |
Thanks! |
Just by adding some
noexcept
Fixes #790 @bremner