Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no source root found issue with Scala 3 for multi-module projects #196

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix no source root found issue with Scala 3 for multi-module projects #196

merged 1 commit into from
Jan 17, 2024

Conversation

jozic
Copy link
Collaborator

@jozic jozic commented Jan 15, 2024 •
edited
Loading

fixes #191

This sets source root relative to the top-level project, not the current project.
This matches what Scala 3 compiler emits by default.

@jozic jozic force-pushed the fix-no-source-root-found branch from 4ca33b3 to 552b787 Compare January 16, 2024 03:11
@jozic jozic marked this pull request as ready for review January 16, 2024 03:20
@jozic
Copy link
Collaborator Author

jozic commented Jan 16, 2024

@ckipp01
if you have a couple of minutes, please check it out.
this should fix a bug with Scala 3 multi-module maven projects.
Thank you!

@jozic
Copy link
Collaborator Author

jozic commented Jan 16, 2024

@gtaylor1981
this hopefully fixes #191
feel free to review it you are interested, especially the test to make sure I didn't miss something

gtaylor1981
gtaylor1981 reviewed Jan 16, 2024
View reviewed changes
Copy link

@gtaylor1981 gtaylor1981 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested these changes with your integration tests, my sample project (from the issue) and finally in my production codebase. They all ran successfully. Thanks again. 👍

@jozic
Copy link
Collaborator Author

jozic commented Jan 16, 2024

@gtaylor1981 thanks for checking! Glad it works for your prod codebase!
I'm aiming to cut a new release this week.

@jozic jozic force-pushed the fix-no-source-root-found branch from 552b787 to 1cb2be9 Compare January 17, 2024 02:52
ckipp01
ckipp01 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks good to me 👍🏼

@jozic jozic merged commit 387dac9 into main Jan 17, 2024
@jozic jozic deleted the fix-no-source-root-found branch January 17, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtaylor1981 gtaylor1981 gtaylor1981 left review comments

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'No source root found' error for module
3 participants
@jozic @ckipp01 @gtaylor1981