Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update Rust version for build-geth workflow #1131

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Mar 4, 2025

Fix CI issue:

Run make libzkp
cd /home/runner/work/go-ethereum/go-ethereum/rollup/ccc/libzkp && make libzkp
make[1]: Entering directory '/home/runner/work/go-ethereum/go-ethereum/rollup/ccc/libzkp'
cargo build --release
error: toolchain 'nightly-2023-12-03-x[8](https://github.com/scroll-tech/go-ethereum/actions/runs/13634481166/job/38150972989#step:5:9)6_64-unknown-linux-gnu' is not installed
help: run `rustup toolchain install nightly-2023-12-03-x86_64-unknown-linux-gnu` to install it
make[1]: *** [Makefile:8: libzkp] Error 1
make[1]: Leaving directory '/home/runner/work/go-ethereum/go-ethereum/rollup/ccc/libzkp'
make: *** [Makefile:[12](https://github.com/scroll-tech/go-ethereum/actions/runs/13634481166/job/38150972989#step:5:13): libzkp] Error 2
Error: Process completed with exit code 2.

Summary by CodeRabbit

  • Chores
    • Updated the continuous integration setup to use a more recent nightly Rust toolchain version.

Copy link

coderabbitai bot commented Mar 4, 2025

Walkthrough

The pull request updates the CI configuration by changing the Rust toolchain version in the workflow file. The version is updated from nightly-2022-12-10 to nightly-2023-12-03, while all other CI steps, including Go installation, code checkout, and build operations, remain unchanged. No modifications were made to any exported or public entities.

Changes

File Change Summary
.github/.../l2geth_ci.yml Updated Rust toolchain version from nightly-2022-12-10 to nightly-2023-12-03 in CI workflow.

Poem

I'm a bunny with a coding heart,
Hopping fast to play my part.
Rust’s new nightly lights my way,
In CI realms I leap and sway.
With CodeRabbit vibes, I cheer today!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 748fb82 and cf27147.

📒 Files selected for processing (1)
  • .github/workflows/l2geth_ci.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: test
  • GitHub Check: check
🔇 Additional comments (1)
.github/workflows/l2geth_ci.yml (1)

40-42: Update Rust Toolchain Version

The updated toolchain version (nightly-2023-12-03) should resolve the CI build failure by ensuring the required Rust nightly version is installed for the make libzkp build step. Please verify that there are no compatibility issues with the rest of the Rust-dependent code.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Thegaram Thegaram merged commit 4797ee9 into develop Mar 4, 2025
9 checks passed
@Thegaram Thegaram deleted the ci-update-build-geth-workflow branch March 4, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants