-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scalar data sources in json metadata descriptor #527
Conversation
Should we take the opportunity to version the schema so we can make these changes without breaking implementations? |
I'll prepare another pull request to start a versioning of the guidelines. |
For me the change in terminology, but I'm not sure with this change how would scalars be represented, can you please clarify, @vpinna80 ? Regarding versioning, I would be careful, because versioning is not included in the standard... |
the scalars would be represented by directly inputing a value domain instead of a structure name: {
"data": [
{
"name": "DS_1",
"metadata": "DS_1_str"
},
{
"name": "an_integer_scalar"
"metadata": "integer"
},
{
"name": "a_country_scalar"
"metadata": "CL_COUNTRY"
}
]
} |
I see, thanks for the clarification. |
@antonio-olleros you have good eyes... I'll make a different proposal. Regarding the versioning, please move that discussion to #531 |
Here's the example with the new proposal, i used two alternative properties to maintain compatibility with the previous json: {
"data": [
{
"name": "DS_1",
"structure": "DS_1_str"
},
{
"name": "an_integer_scalar"
"valuedomain": "integer"
},
{
"name": "a_country_scalar"
"valuedomain": "CL_COUNTRY"
}
]
} |
Thanks for the suggestion, @vpinna80! Still not fully convinced, for me the data types are not the same as valuedomains, but the valuedomains are defined on basic scalar types (see: https://sdmx-twg.github.io/vtl/2.1/html/user_manual/model.html#the-variables-and-value-domains-artefacts). I think this is relevant enough to be worth having a meeting... |
I hope there will be one session about it in Frankfurt, right @linardian ? |
Yes, of course! I am inserting this topic in the agenda. |
7de70fa
to
f008ac7
Compare
This patch allows the json metadata file to also represent scalar values. It's a terminology change to make the change more evident.