Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BinaryClassifierPrecisionEfficacy metric #714

Merged
merged 15 commits into from
Feb 7, 2025
Merged

Add BinaryClassifierPrecisionEfficacy metric #714

merged 15 commits into from
Feb 7, 2025

Conversation

R-Palazzo
Copy link
Contributor

CU-86b3m9u4d
Resolve #711

@R-Palazzo R-Palazzo self-assigned this Feb 4, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner February 4, 2025 16:29
@sdv-team
Copy link
Contributor

sdv-team commented Feb 4, 2025

Task linked: CU-86b3m9u4d SDMetrics - Add BinaryClassifierPrecisionEfficacy metric #711

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.64865% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.06%. Comparing base (321eae7) to head (5b449e7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdmetrics/single_table/data_augmentation/base.py 98.94% 1 Missing ⚠️
sdmetrics/visualization.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
+ Coverage   94.91%   95.06%   +0.15%     
==========================================
  Files         106      110       +4     
  Lines        4126     4273     +147     
==========================================
+ Hits         3916     4062     +146     
- Misses        210      211       +1
Flag Coverage Δ
integration 79.07% <90.54%> (+0.43%) ⬆️
unit 82.42% <98.64%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amontanez24
amontanez24 reviewed Feb 5, 2025
View reviewed changes
@R-Palazzo
Copy link
Contributor Author

Thanks for the review @amontanez24. I addressed the comments in 791c7d5 and aafdd1e with some refactoring as you recommended

R-Palazzo
R-Palazzo commented Feb 5, 2025
View reviewed changes
sdmetrics/visualization.py
@@ -32,7 +32,7 @@ def wrapper(*args, **kwargs):
ipython_interpreter = str(get_ipython())
if 'ZMQInteractiveShell' in ipython_interpreter and 'iframe' in renderers:
# This means we are using jupyter notebook
pio.renderers.default = 'vscode'
pio.renderers.default = 'iframe'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that this change was accidentally added in a previous PR, so I reverted it.

@R-Palazzo R-Palazzo requested a review from amontanez24 February 5, 2025 18:04
@R-Palazzo R-Palazzo force-pushed the issue-711-BinaryClassifierPrecisionEfficacy branch from b946f19 to 94f83e9 Compare February 6, 2025 11:15
amontanez24
amontanez24 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @frances-h Can you take a look? You know the details of the algorithm better than I do

@R-Palazzo R-Palazzo merged commit 15ab6df into main Feb 7, 2025
47 checks passed
@R-Palazzo R-Palazzo deleted the issue-711-BinaryClassifierPrecisionEfficacy branch February 7, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@frances-h frances-h frances-h approved these changes

Assignees

@R-Palazzo R-Palazzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BinaryClassifierPrecisionEfficacy metric
4 participants
@R-Palazzo @sdv-team @amontanez24 @frances-h