-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python 3.13 #721
Support python 3.13 #721
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 111 111
Lines 4305 4305
=======================================
Hits 4094 4094
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- if: matrix.python-version == 3.13 | ||
name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
python -m pip install invoke .[xgboost,test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change this to support pomegranate again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amontanez24 the version of pomegranate we are currently using is incompatible with 3.13, we'd need to update to the new pomegranate API first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this message to say we don't support python 3.13 yet?
'Please install pomegranate with `pip install sdmetrics[pomegranate]`' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amontanez24 added
28b439c
to
d99cd5b
Compare
@amontanez24 can you update the required checks from |
done |
Resolves #645
CU-86b2mqatx