Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.13 #721

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Support python 3.13 #721

merged 2 commits into from
Feb 20, 2025

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Feb 10, 2025

Resolves #645

CU-86b2mqatx

@rwedge rwedge requested a review from a team as a code owner February 10, 2025 22:47
@rwedge rwedge requested review from amontanez24 and removed request for a team February 10, 2025 22:47
@sdv-team
Copy link
Contributor

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (6946835) to head (d99cd5b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         111      111           
  Lines        4305     4305           
=======================================
  Hits         4094     4094           
  Misses        211      211           
Flag Coverage Δ
integration 79.21% <ø> (ø)
unit 82.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +40 to +44
- if: matrix.python-version == 3.13
name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install invoke .[xgboost,test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change this to support pomegranate again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amontanez24 the version of pomegranate we are currently using is incompatible with 3.13, we'd need to update to the new pomegranate API first

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this message to say we don't support python 3.13 yet?

'Please install pomegranate with `pip install sdmetrics[pomegranate]`'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amontanez24 added

@rwedge rwedge requested a review from R-Palazzo February 14, 2025 22:51
@rwedge rwedge force-pushed the issue-645-support-py313 branch from 28b439c to d99cd5b Compare February 19, 2025 22:10
@rwedge
Copy link
Contributor Author

rwedge commented Feb 20, 2025

@amontanez24 can you update the required checks from macos-latest, 3.12 to macos-latest, 3.13?

@amontanez24
Copy link
Contributor

@amontanez24 can you update the required checks from macos-latest, 3.12 to macos-latest, 3.13?

done

@rwedge rwedge merged commit a67d711 into main Feb 20, 2025
55 checks passed
@rwedge rwedge deleted the issue-645-support-py313 branch February 20, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.13 (excluding pomegranate)
4 participants